Skip to content

Comments

Working set fix#722

Merged
Tinche merged 3 commits intopython-attrs:mainfrom
mm-andritz:working_set_fix
Feb 23, 2026
Merged

Working set fix#722
Tinche merged 3 commits intopython-attrs:mainfrom
mm-andritz:working_set_fix

Conversation

@mm-andritz
Copy link
Contributor

@mm-andritz mm-andritz commented Feb 20, 2026

Fixes #721

@Tinche
Copy link
Member

Tinche commented Feb 20, 2026

LGTM but please add a docstring to the unit test explaining the case being tested (doesn't need to be long).

@Tinche Tinche self-requested a review February 20, 2026 13:30
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 20, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 54 untouched benchmarks

Comparing mm-andritz:working_set_fix (e6933fa) with main (fd887b7)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (a4230d1) during the generation of this report, so fd887b7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@Tinche Tinche mentioned this pull request Feb 22, 2026
Open
@Tinche Tinche merged commit 573915b into python-attrs:main Feb 23, 2026
14 checks passed
@Tinche
Copy link
Member

Tinche commented Feb 23, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tinche Tinche Tinche approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AttributeError: working_set when using include_subclasses inside struct_hook_factory

3 participants

@mm-andritz @Tinche @matmel